Add info about node:${module} syntax for nodejs_compat (#4485)

* Add info about `node:${module}` syntax for nodejs_compat * Update error message for nodejs_compat in wrangler tests * Fix error message matched about nodejs_compat
cloudflare · Dec 18, 2023 · cd4f63a · cd4f63a
1 parent c628de5
commit cd4f63a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/packages/wrangler/src/__tests__/deploy.test.ts b/packages/wrangler/src/__tests__/deploy.test.ts
@@ -7717,7 +7717,7 @@ export default{
 			expect(
 				esbuild.formatMessagesSync(err?.errors ?? [], { kind: "error" }).join()
 			).toMatch(
-				/The package "path" wasn't found on the file system but is built into node\.\s+Add "node_compat = true" to your wrangler\.toml file to enable Node.js compatibility\./
+				/The package "path" wasn't found on the file system but is built into node\.\s+Add "node_compat = true" to your wrangler\.toml file and make sure to prefix the module name with "node:" to enable Node.js compatibility\./
 			);
 		});
 

diff --git a/packages/wrangler/src/__tests__/pages/functions-build.test.ts b/packages/wrangler/src/__tests__/pages/functions-build.test.ts
@@ -437,7 +437,7 @@ export default {
 			'The package "node:async_hooks" wasn\'t found on the file system but is built into node.'
 		);
 		expect(std.err).toContain(
-			'Add the "nodejs_compat" compatibility flag to your Pages project to enable Node.js compatibility.'
+			'Add the "nodejs_compat" compatibility flag to your Pages project and make sure to prefix the module name with "node:" to enable Node.js compatibility.'
 		);
 	});
 

diff --git a/packages/wrangler/src/deployment-bundle/build-failures.ts b/packages/wrangler/src/deployment-bundle/build-failures.ts
@@ -30,7 +30,7 @@ export function rewriteNodeCompatBuildFailure(
 				forPages
 					? 'Add the "nodejs_compat" compatibility flag to your Pages project'
 					: 'Add "node_compat = true" to your wrangler.toml file'
-			} to enable Node.js compatibility.`;
+			} and make sure to prefix the module name with "node:" to enable Node.js compatibility.`;
 
 			error.notes = [
 				{