New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have deployment view output in table #2844
Have deployment view output in table #2844
Conversation
|
Name | Type |
---|---|
wrangler | Minor |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4327065671/npm-package-wrangler-2844 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/2844/npm-package-wrangler-2844 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4327065671/npm-package-wrangler-2844 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4327065671/npm-package-cloudflare-pages-shared-2844 Note that these links will no longer work once the GitHub Actions artifact expires. |
Codecov Report
@@ Coverage Diff @@
## jacobmgevans/deployment-view-rollback #2844 +/- ##
========================================================================
Coverage ? 74.13%
========================================================================
Files ? 166
Lines ? 10319
Branches ? 2768
========================================================================
Hits ? 7650
Misses ? 2669
Partials ? 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks like a great refactor and polishing up of the output!! There are a couple things to fix and a few linter issues.
e1c19ad
to
89a2d64
Compare
89a2d64
to
70da2b9
Compare
70da2b9
to
1df0f96
Compare
It might be a good idea to hide the contents of the script behind a flag or something similar - if someone has a large worker, such as a 5mb one, this would flood their terminal Could also truncate the contents of the script if a flag isn't desired |
@admah Interesting thought. |
* Add suggested changes and update wrangler docs * Separate content into option on view command --------- Co-authored-by: jjohnson <jjohnson@cloudflare.com>
* Add suggested changes and update wrangler docs * Separate content into option on view command --------- Co-authored-by: jjohnson <jjohnson@cloudflare.com>
* Add suggested changes and update wrangler docs * Separate content into option on view command --------- Co-authored-by: jjohnson <jjohnson@cloudflare.com>
* Deployment Details Added a positional in the 'Deployments' command <deployment-id>. <deployment-id> will get the details of the deployment, including versioned script, bindings, and usage model information. changeset added snapshot for commands updated removed stray quotes * Deployment Rollbacks Created a subcommand on deployments that allows for rolling back a deployment to a previous ID provided. Changed the command structure to have 2 subcommands view and rollback Improved the Changeset messaging and combined rollback Update help messages Added comfirmation prompt to Rollback Implemented --yes flag with tests Updated tests comfirmation handles non-TTY environments automatically fixed tests to reflect that and removed --yes option tests breaking in CI Turn off chalk in tests Update messaging with new copy for confirm prompt matching dashboard & removing the PUT response in output snapshots updated rollback accounts URL * # This is a combination of 2 commits. # This is the 1st commit message: Update rollback fetch call and remove deployments request from publish # This is the commit message #2: destructure the one value we want from the result * Update rollback fetch call and remove deployments request from publish destructure the one value we want from the result Have script upload msw always return response body Update deployment tests Fixed misc tests Delete index.js Added check for request on rollback tests Fix issue with wrangler version appearing after prompt * Fix `next(param)` in Pages Plugins (#2789) * Add duplex to r2 put (#2793) * Add changeset (#2795) * Version Packages (#2791) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Add hyphens to all deployment ids * Merge * Automatically rollback to previous deployment if deployment id is not specified (#2841) Co-authored-by: jjohnson <jjohnson@cloudflare.com> * Have deployment view output in table (#2844) * Add suggested changes and update wrangler docs * Separate content into option on view command --------- Co-authored-by: jjohnson <jjohnson@cloudflare.com> * Add message to rollback and restructre rollback commands (#2888) * Add rollback reason * fixup: Cleanup hanging prompt mocks in deployments tests * Change structure for rollback commands --------- Co-authored-by: jjohnson <jjohnson@cloudflare.com> Co-authored-by: Samuel Macleod <smacleod@cloudflare.com> * Remove showing script content in deployment view --------- Co-authored-by: jjohnson <jjohnson@cloudflare.com> Co-authored-by: Greg Brimble <gbrimble@cloudflare.com> Co-authored-by: Somhairle MacLeòid <smacleod@cloudflare.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Joshua Johnson <jspspike@gmail.com>
Have new view for
wrangler deployment view
commandExample output
Author has included the following, where applicable:
Reviewer has performed the following, where applicable:
Fixes # [insert issue number].