Fix next(param) in Pages Plugins
#2789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ab79130 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4257287817/npm-package-wrangler-2789You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/2789/npm-package-wrangler-2789Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4257287817/npm-package-wrangler-2789 dev path/to/script.jsAdditional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4257287817/npm-package-cloudflare-pages-shared-2789Note that these links will no longer work once the GitHub Actions artifact expires. |
Codecov Report
@@ Coverage Diff @@
## main #2789 +/- ##
==========================================
+ Coverage 73.97% 74.00% +0.02%
==========================================
Files 166 166
Lines 10163 10163
Branches 2705 2705
==========================================
+ Hits 7518 7521 +3
+ Misses 2645 2642 -3
|
GregBrimble
commented
Feb 23, 2023
| @@ -133,15 +133,19 @@ export default function (pluginArgs: unknown) { | |||
| const handlerIterator = executeRequest(request, relativePathname); | |||
| const pluginNext = async (input?: RequestInfo, init?: RequestInit) => { | |||
| if (input !== undefined) { | |||
| request = new Request(input, init); | |||
| let url = input; | |||
There was a problem hiding this comment.
Was forgotten about when it was added to the OG template.
GregBrimble
force-pushed
the
pages-plugin-fixes
branch
from
fdfc232
to
ab79130
Compare
jrf0110
reviewed
Feb 23, 2023
| } | ||
|
|
||
| const result = handlerIterator.next(); | ||
| // Note we can't use `!result.done` because this doesn't narrow to the correct type | ||
| if (result.done === false) { | ||
| const { handler, params, path } = result.value; | ||
| const context = { | ||
| request, | ||
| request: new Request(request.clone()), |
There was a problem hiding this comment.
Why can't we just say: request: request.clone()?
There was a problem hiding this comment.
jrf0110
approved these changes
Feb 23, 2023
Merged
jspspike
pushed a commit
that referenced
this pull request
Feb 27, 2023
jspspike
pushed a commit
that referenced
this pull request
Mar 13, 2023
jspspike
pushed a commit
that referenced
this pull request
Mar 15, 2023
jspspike
pushed a commit
that referenced
this pull request
Mar 16, 2023
jspspike
added a commit
that referenced
this pull request
Mar 16, 2023
* Deployment Details Added a positional in the 'Deployments' command <deployment-id>. <deployment-id> will get the details of the deployment, including versioned script, bindings, and usage model information. changeset added snapshot for commands updated removed stray quotes * Deployment Rollbacks Created a subcommand on deployments that allows for rolling back a deployment to a previous ID provided. Changed the command structure to have 2 subcommands view and rollback Improved the Changeset messaging and combined rollback Update help messages Added comfirmation prompt to Rollback Implemented --yes flag with tests Updated tests comfirmation handles non-TTY environments automatically fixed tests to reflect that and removed --yes option tests breaking in CI Turn off chalk in tests Update messaging with new copy for confirm prompt matching dashboard & removing the PUT response in output snapshots updated rollback accounts URL * # This is a combination of 2 commits. # This is the 1st commit message: Update rollback fetch call and remove deployments request from publish # This is the commit message #2: destructure the one value we want from the result * Update rollback fetch call and remove deployments request from publish destructure the one value we want from the result Have script upload msw always return response body Update deployment tests Fixed misc tests Delete index.js Added check for request on rollback tests Fix issue with wrangler version appearing after prompt * Fix `next(param)` in Pages Plugins (#2789) * Add duplex to r2 put (#2793) * Add changeset (#2795) * Version Packages (#2791) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Add hyphens to all deployment ids * Merge * Automatically rollback to previous deployment if deployment id is not specified (#2841) Co-authored-by: jjohnson <jjohnson@cloudflare.com> * Have deployment view output in table (#2844) * Add suggested changes and update wrangler docs * Separate content into option on view command --------- Co-authored-by: jjohnson <jjohnson@cloudflare.com> * Add message to rollback and restructre rollback commands (#2888) * Add rollback reason * fixup: Cleanup hanging prompt mocks in deployments tests * Change structure for rollback commands --------- Co-authored-by: jjohnson <jjohnson@cloudflare.com> Co-authored-by: Samuel Macleod <smacleod@cloudflare.com> * Remove showing script content in deployment view --------- Co-authored-by: jjohnson <jjohnson@cloudflare.com> Co-authored-by: Greg Brimble <gbrimble@cloudflare.com> Co-authored-by: Somhairle MacLeòid <smacleod@cloudflare.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Joshua Johnson <jspspike@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test:
Associated docs issues/PR:
Author has included the following, where applicable:
Reviewer has performed the following, where applicable:
Fixes # [insert issue number].