Versions deployments commands #5224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2b3b8d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mrbbot
reviewed
Mar 12, 2024
packages/wrangler/src/__tests__/versions/deployments/deployments.list.test.ts
Outdated
Show resolved
Hide resolved
packages/wrangler/src/__tests__/versions/deployments/deployments.list.test.ts
Outdated
Show resolved
Hide resolved
packages/wrangler/src/__tests__/versions/deployments/deployments.status.test.ts
Outdated
Show resolved
Hide resolved
packages/wrangler/src/__tests__/versions/deployments/deployments.list.test.ts
Outdated
Show resolved
Hide resolved
| }; | ||
|
|
||
| /** | ||
| * Render a set of labelled values into a string with the values aligned |
There was a problem hiding this comment.
Example inputs/outputs in this comment might be nice.
RamIdeas
force-pushed
the
versions-deployments-commands
branch
from
2e1a960
to
50911dd
Compare
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8262904278/npm-package-wrangler-5224You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5224/npm-package-wrangler-5224Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8262904278/npm-package-wrangler-5224 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8262904278/npm-package-create-cloudflare-5224 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8262904278/npm-package-cloudflare-kv-asset-handler-5224npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8262904278/npm-package-miniflare-5224npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8262904278/npm-package-cloudflare-pages-shared-5224npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8262904278/npm-package-cloudflare-vitest-pool-workers-5224Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5224 +/- ##
==========================================
+ Coverage 70.99% 71.27% +0.27%
==========================================
Files 304 309 +5
Lines 15927 16075 +148
Branches 4080 4105 +25
==========================================
+ Hits 11308 11458 +150
+ Misses 4619 4617 -2
|
RamIdeas
force-pushed
the
versions-list-command
branch
from
f1b4772
to
a608e35
Compare
RamIdeas
force-pushed
the
versions-deployments-commands
branch
from
aac9941
to
ad4879e
Compare
mrbbot
approved these changes
Mar 12, 2024
RamIdeas
force-pushed
the
versions-list-command
branch
from
a608e35
to
2f6d5e8
Compare
RamIdeas
force-pushed
the
versions-deployments-commands
branch
from
ad4879e
to
1041b08
Compare
RamIdeas
force-pushed
the
versions-list-command
branch
from
2f6d5e8
to
1310333
Compare
RamIdeas
force-pushed
the
versions-deployments-commands
branch
2 times, most recently
from
85d1c08
to
d8f425e
Compare
RamIdeas
force-pushed
the
versions-list-command
branch
2 times, most recently
from
8c2292a
to
efd3514
Compare
… writing it directly to stdout this will allow for nested alignment
in all versions/deployments commands
RamIdeas
force-pushed
the
versions-deployments-commands
branch
from
104f255
to
2b3b8d6
Compare
Merged
taylorlee
reviewed
Mar 19, 2024
| ([version_id, percentage]) => ({ version_id, percentage }) | ||
| ), | ||
| annotations: { | ||
| "workers/triggered_by": "deployment", |
There was a problem hiding this comment.
Ahh, whoops, this was supposed to be redacted for Deployments as it was for versions, sorry for the confusion!
taylorlee
added a commit
to taylorlee/workers-sdk
that referenced
this pull request
Mar 20, 2024
This got lost in translation: cloudflare#5224 (comment)
3 tasks
RamIdeas
pushed a commit
that referenced
this pull request
Mar 20, 2024
…5306) This got lost in translation: #5224 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test
This PR implements the
wrangler deployments listandwrangler deployments statuscommands. These will replace the existing deployments commands but, for now, you must specify--experimental-gradual-rolloutsto run these new commands, for example:Author has addressed the following