-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move annotations under metadata in create-worker-upload-form #5238
Conversation
in create-worker-upload-form
🦋 Changeset detectedLatest commit: a397bf9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
annotations: { | ||
"workers/message": props.message, | ||
"workers/tag": props.tag, | ||
"workers/triggered_by": "wrangler", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove triggered_by while we're here? As this will no longer be overridable soon.
@@ -111,6 +111,7 @@ export interface WorkerMetadata { | |||
placement?: CfPlacement; | |||
tail_consumers?: CfTailConsumer[]; | |||
limits?: CfUserLimits; | |||
annotations?: Record<string, string>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is the single field that's not supported in script upload, but supported in version upload, is it worth calling that out in a comment? Is it fairly awkward to split the types into the set of fields supported by either API?
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8281575432/npm-package-wrangler-5238 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5238/npm-package-wrangler-5238 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8281575432/npm-package-wrangler-5238 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8281575432/npm-package-create-cloudflare-5238 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8281575432/npm-package-cloudflare-kv-asset-handler-5238 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8281575432/npm-package-miniflare-5238 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8281575432/npm-package-cloudflare-pages-shared-5238 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8281575432/npm-package-cloudflare-vitest-pool-workers-5238 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5238 +/- ##
==========================================
+ Coverage 71.26% 71.45% +0.18%
==========================================
Files 309 309
Lines 16075 16081 +6
Branches 4105 4103 -2
==========================================
+ Hits 11456 11490 +34
+ Misses 4619 4591 -28
|
in `versions list`
Snapshots need updating to accommodate the extra empty line that was added. |
I added an issue to track adding the missing tests #5254 |
What this PR solves / how to test
This fixes annotations in versions upload to match where the api expects to find them
Author has addressed the following