-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add helpful logging to --experimental-versions commands #5419
Conversation
defaults applied keep the output the same as before we can change the defaults to be more sane in a follow-up after devweek
🦋 Changeset detectedLatest commit: 5f7ecb1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8466904788/npm-package-wrangler-5419 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5419/npm-package-wrangler-5419 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8466904788/npm-package-wrangler-5419 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8466904788/npm-package-create-cloudflare-5419 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8466904788/npm-package-cloudflare-kv-asset-handler-5419 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8466904788/npm-package-miniflare-5419 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8466904788/npm-package-cloudflare-pages-shared-5419 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8466904788/npm-package-cloudflare-vitest-pool-workers-5419 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5419 +/- ##
==========================================
+ Coverage 72.19% 72.26% +0.07%
==========================================
Files 322 322
Lines 16666 16670 +4
Branches 4260 4258 -2
==========================================
+ Hits 12032 12047 +15
+ Misses 4634 4623 -11
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Very minor non-blocking comments, but feel free to merge.
What this PR solves / how to test
This PR adds helpful logging to
--experimental-versions
commands.The changes in packages/cli are a refactor and do not effect the output by default but now there are options to override the default formatting.
CR: https://jira.cfdata.org/browse/CR-850334
Author has addressed the following