Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Discord server url #5482

Merged
merged 3 commits into from
Apr 21, 2024
Merged

Conversation

DaniFoldi
Copy link
Contributor

What this PR solves / how to test

Hi 👋,

I was originally reproducing and fixing a completely unrelated bug in c3, but noticed the old url in the summary after creating a project. Since the new URL is preferred, I thought I'd PR it, and a quick search found another 20 or so matches.

The only remaining instances of the old .gg/cloudflaredev one are in changelog entries, which I didn't want to modify.

The changeset for this is a patch to every touched package, not sure if this is worth releasing kv-asset-handler for. Also since Hyperdrive is now GA (🎉), the banner might go away so if this would cause merge conflicts, happy to undo any conflicting ones (also Constellation).

Fixes #[insert GH or internal issue number(s)].

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included, but something broke and didn't run locally so 🤞
    • Not necessary because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation

@DaniFoldi DaniFoldi requested review from a team as code owners April 2, 2024 20:13
Copy link

changeset-bot bot commented Apr 2, 2024

🦋 Changeset detected

Latest commit: a0665f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
create-cloudflare Patch
format-errors Patch
@cloudflare/kv-asset-handler Patch
miniflare Patch
workers-playground Patch
wrangler Patch
sites-app Patch
@cloudflare/pages-shared Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DaniFoldi DaniFoldi mentioned this pull request Apr 2, 2024
9 tasks
Copy link
Contributor

github-actions bot commented Apr 2, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8774964110/npm-package-wrangler-5482

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5482/npm-package-wrangler-5482

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8774964110/npm-package-wrangler-5482 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8774964110/npm-package-create-cloudflare-5482 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8774964110/npm-package-cloudflare-kv-asset-handler-5482
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8774964110/npm-package-miniflare-5482
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8774964110/npm-package-cloudflare-pages-shared-5482
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8774964110/npm-package-cloudflare-vitest-pool-workers-5482

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.51.2 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240405.2
workerd 1.20240405.0 1.20240405.0
workerd --version 1.20240405.0 2024-04-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.51%. Comparing base (2789f26) to head (40c4819).
Report is 50 commits behind head on main.

❗ Current head 40c4819 differs from pull request most recent head a0665f2. Consider uploading reports for the commit a0665f2 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5482      +/-   ##
==========================================
+ Coverage   72.44%   72.51%   +0.06%     
==========================================
  Files         331      331              
  Lines       17298    17298              
  Branches     4422     4422              
==========================================
+ Hits        12532    12544      +12     
+ Misses       4766     4754      -12     
Files Coverage Δ
packages/wrangler/src/constellation/utils.ts 93.33% <100.00%> (ø)

... and 6 files with indirect coverage changes

@DaniFoldi
Copy link
Contributor Author

Okay, apparently the hyperdrive warnings was removed

Copy link
Contributor

@jculvey jculvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C3 changes lgtm

Copy link
Member

@WalshyDev WalshyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from community side.

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to double check that there are no e2e tests that will break from this...
Might be worth just pushing up a draft PR that is pushed to the cloudflare fork.

.changeset/wise-beds-buy.md Outdated Show resolved Hide resolved
@petebacondarwin petebacondarwin self-assigned this Apr 21, 2024
DaniFoldi and others added 3 commits April 21, 2024 20:17
@petebacondarwin petebacondarwin merged commit 1b7739e into cloudflare:main Apr 21, 2024
39 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants