Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C3: Stop running e2e on forks #5596

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Conversation

jculvey
Copy link
Contributor

@jculvey jculvey commented Apr 11, 2024

What this PR solves / how to test

This is an attempt to resolve the problem of C3 e2e tests being run on forks. Each workflow currently checks if: github.repository_owner == 'cloudflare', but despite this c3 e2e tests are still being run on forks. Docs seem to indicate that this doesn't need to be escaped as an expression ${{ }}, but it seems worth a shot anyway.

Here's a few recent examples:

#5547
#5483
#5482
#5458

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: no functionality changed
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because: no user facing changes
  • Public documentation

@jculvey jculvey requested a review from a team as a code owner April 11, 2024 18:39
Copy link

changeset-bot bot commented Apr 11, 2024

⚠️ No Changeset found

Latest commit: dac57e0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8651657627/npm-package-wrangler-5596

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5596/npm-package-wrangler-5596

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8651657627/npm-package-wrangler-5596 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8651657627/npm-package-create-cloudflare-5596 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8651657627/npm-package-cloudflare-kv-asset-handler-5596
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8651657627/npm-package-miniflare-5596
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8651657627/npm-package-cloudflare-pages-shared-5596
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8651657627/npm-package-cloudflare-vitest-pool-workers-5596

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.50.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240405.1
workerd 1.20240405.0 1.20240405.0
workerd --version 1.20240405.0 2024-04-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@petebacondarwin petebacondarwin merged commit 69577b9 into main Apr 12, 2024
35 of 43 checks passed
@petebacondarwin petebacondarwin deleted the c3-stop-running-e2e-on-forks branch April 12, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants