Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wrangler): Make jest inline snapshots work with prettier 3 #5851

Merged
merged 1 commit into from
May 16, 2024

Conversation

CarmenPopoviciu
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu commented May 16, 2024

Jest inline snapshots do not work with prettier verision 3. For more details please refer to
jestjs/jest#14305.

This commit fixes that by applying the recommended fix as per GitHub issue thread above.

What this PR solves / how to test

Fixes #[insert GH or internal issue number(s)].

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: jest config change
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: jest config change
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because: jest config change
  • Public documentation

Jest inline snapshots do not work with prettier verision `3`.
For more details please refer to
jestjs/jest#14305.

This commit fixes that by applying the recommended fix as per
GitHub issue thread above.
@CarmenPopoviciu CarmenPopoviciu requested a review from a team as a code owner May 16, 2024 09:09
Copy link

changeset-bot bot commented May 16, 2024

⚠️ No Changeset found

Latest commit: 5ae2fcb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9109619137/npm-package-wrangler-5851

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5851/npm-package-wrangler-5851

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9109619137/npm-package-wrangler-5851 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9109619137/npm-package-create-cloudflare-5851 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9109619137/npm-package-cloudflare-kv-asset-handler-5851
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9109619137/npm-package-miniflare-5851
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9109619137/npm-package-cloudflare-pages-shared-5851
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9109619137/npm-package-cloudflare-vitest-pool-workers-5851

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.56.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240512.0
workerd 1.20240512.0 1.20240512.0
workerd --version 1.20240512.0 2024-05-12

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@CarmenPopoviciu CarmenPopoviciu merged commit 95a1fa1 into main May 16, 2024
19 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the carmen/make-snapshots-work-again branch May 16, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants