[Bug]: Prettier v3 doesn't work with jest-snapshots

[TAGraves]

Version

29.6.1

Steps to reproduce

1. Install prettier@3.0.0, which was just released yesterday
2. Write a test that would generate an inline snapshot, like:

test('snapshot', () => {
  expect('abc').toMatchInlineSnapshot();
});

Expected behavior

The inline snapshot is updated

Actual behavior

Jest fails with

  ● Test suite failed to run

    TypeError: prettier.resolveConfig.sync is not a function

      at runPrettier (node_modules/jest-snapshot/build/InlineSnapshots.js:308:30)

Additional context

Prettier just released v3, which removed this line that added the sync function to resolveConfig. It looks like eslint-plugin-prettier ran into a similar problem. based on this issue.

Environment

System:
    OS: macOS 13.4.1
    CPU: (10) arm64 Apple M1 Pro
  Binaries:
    Node: 18.16.0 - ~/.nvm/versions/node/v18.16.0/bin/node
    npm: 9.5.1 - ~/.nvm/versions/node/v18.16.0/bin/npm
    pnpm: 8.5.1 - ~/Library/pnpm/pnpm
  npmPackages:
    jest: ^29.6.0 => 29.6.1

[mrazauskas]

Confirmed: if Prettier v3 is installed, Jest fails to update or create inline snapshots. Existing inline snapshots work fine if they are passing.

Seems like this is similar to what eslint-plugin-prettier was facing – TypeError: prettier.resolveConfig.sync is not a function. See prettier/eslint-plugin-prettier#562

[mrazauskas]

Seems like it is possible to add prettierPath: null to Jest config. Formatting can be done using Prettier outside of Jest run. That can be a workaround until solution will be found.

[SimenB]

I doubt we'll ever support Prettier v3 as we need it to work synchronously.

However, we might be able to add support for @prettier/sync.

[SimenB]

That module is currently broken (prettier/prettier-synchronized#5), but I think it should work after that is released. We'll then have to look at the version of prettier we load, and decide which API to use

[mrazauskas]

@prettier/sync is hardcoding the path to prettier, so it will not work with prettierPath option. I was thinking, what if we would vendor it and adjust to the needs of Jest.

[fisker]

Maybe @prettier/sync shoud expost a factory to accept prettierPath instead?