This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
refactor and document wrangler dev #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let client = client.to_owned(); | ||
| let server_config = server_config.to_owned(); | ||
| let preview_id = preview_id.to_owned(); | ||
| async move { |
There was a problem hiding this comment.
mebbe not here, but i'd suggest pulling these nested anonymous functions into named functions for clarity. not 100% necessary tho.
There was a problem hiding this comment.
I actually spent like an hour trying to figure out how to do this but couldn't because of the move statements. Happy for some help on this one
EverlastingBugstopper
force-pushed
the
avery/cleanup
branch
from
9b84f1c
to
43d1248
Compare
ashleymichal
approved these changes
Apr 23, 2020
| /// and any response headers sent from the preview service | ||
| /// that don't have the prefix must be removed | ||
| /// and response headers that do have the prefix | ||
| /// must have the prefix stripped |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shouldn't change any behavior but it does add a decent chunk of comments, remove dependence on the
futurescrate, and paves the way for easily adding edge connectivity.