This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
fix: use x86_64 arch for pre-built downloads on M1 devices #1876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's worth noting that this fix does not change any behavior on any of our previously supported platforms. And for posterity, it relies on the target M1 / aarch64/arm64 Apple device to have Rosetta 2 installed. This should already be the case, but if not, it can be installed by running: |
Electroid
approved these changes
Apr 26, 2021
nataliescottdavidson
approved these changes
Apr 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR forces the use of a pre-built x86_64 binary on a aarch64/arm64 Apple system. For M1 devices specifically, it will fix
wrangler generate, andwrangler buildfortype = "rust"wrangler projects.There is another semi-related PR that will fix some additional rust/wasm issues in our template repo here: cloudflare/rustwasm-worker-template#21, which would be nice to have merged along with this.