Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

ux: add HTTP prefix to publish command output. #198

Merged

Conversation

elithrar
Copy link
Contributor

@elithrar elithrar commented Jun 2, 2019

Prefix "https://" in front of the "script available" output to allow shells to automatically detect it as a link.

This was the only relevant instance - e.g. other instances are typically referring to the domain structure, and not a deployed script.

/mnt/c/Users/Gamer/repos/wrangler (master) ✔ ➜  rg '\.workers\.dev'
README.md
63:    By default, `publish` will make your worker available at `<project-name>.<subdomain>.workers.dev`.
66:    explicitly enable deployment to `<project-name>.<subdomain>.workers.dev`, you can set `private = false`. 
npm/README.md
63:    By default, `publish` will make your worker available at `<project-name>.<subdomain>.workers.dev`.
66:    explicitly enable deployment to `<project-name>.<subdomain>.workers.dev`, you can set `private = false`. 
src/commands/subdomain.rs
65:        "{} Registering your subdomain, {}.workers.dev, this could take up to a minute.",
92:                "⛔ This account already has a registered subdomain. You can only register one subdomain per account. Your subdomain is {}.workers.dev \n Status Code: {}\n Msg: {}",
src/commands/publish/mod.rs
175:            "🥳 Successfully made your script available at {}.{}.workers.dev",

Prefix "https://" in front of the "script available" output to allow shells to automatically detect it as a link.
@elithrar
Copy link
Contributor Author

elithrar commented Jun 2, 2019

Example:

🍺 Successfully published your script..
🍺 Successfully made your script available at https://lb-functions-example.silverlock.workers.dev
✨ Success! Your worker was successfully published. ✨

Copy link
Contributor

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much for the thoughtful PR! <3

@ashleygwilliams ashleygwilliams merged commit 7e7b03d into cloudflare:master Jun 3, 2019
@ashleygwilliams ashleygwilliams added this to the 1.0.1 milestone Jun 3, 2019
@kristianfreeman kristianfreeman added the feature Feature requests and suggestions label Jul 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Feature requests and suggestions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants