Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Pin webpack version #228

Merged
merged 1 commit into from
Jun 7, 2019
Merged

Pin webpack version #228

merged 1 commit into from
Jun 7, 2019

Conversation

xtuc
Copy link
Member

@xtuc xtuc commented Jun 7, 2019 •
edited
Loading

Adds a better control over webpack's version, avoiding possible upstream
issues.

Also we depend on one internal.

@xtuc
feat: pin webpack version
17d7508 
Adds a better control over webpack's version, avoiding possible upstream
issues.
@xtuc
Copy link
Member Author

xtuc commented Jun 7, 2019

Maybe that should even be a peerDependecy?

ashleygwilliams
ashleygwilliams approved these changes Jun 7, 2019
View reviewed changes
Copy link
Contributor

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no real opinion on whether this should be a peer Dep or not- i think semantically it is one, but peer Deps are not really commonly used and their impl can be weird sometimes. i leave it up to you!

@ashleygwilliams ashleygwilliams added this to the 1.1.0 milestone Jun 7, 2019
@xtuc
Copy link
Member Author

xtuc commented Jun 7, 2019

For now I would prefer the security, just pin it.

@xtuc xtuc merged commit 332b8bb into master Jun 7, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat-pin-webpack-version branch June 7, 2019 12:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashleygwilliams ashleygwilliams ashleygwilliams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@xtuc @ashleygwilliams