This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Guard test against potential races #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you run `wrangler build` it will try to install the `npm` dependencies of the user's project and, in development mode, the one from `wranglerjs`. This can lead to races if two build were launch at the same time. To avoid that we use a file lock and make wrangler wait if it's already locked. However, it turns out that wrangler will not wait and run `npm install` regardless. This change avoids running multiple `wrangler build` at the same time during our unit tests.
EverlastingBugstopper
requested review from
EverlastingBugstopper,
ashleymichal,
ashleygwilliams and
gabbifish
ashleygwilliams
approved these changes
Sep 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you run
wrangler buildit will try to install thenpmdependencies of the user's project and, in development mode, the
one from
wranglerjs. This can lead to races if two build were launchat the same time. To avoid that we use a file lock and make wrangler
wait if it's already locked. However, it turns out that wrangler will
not wait and run
npm installregardless.This change avoids running multiple
wrangler buildat the same timeduring our unit tests.