Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

[wip] [dev] Disallow localhost as backend #964

Closed

Conversation

EverlastingBugstopper
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper commented Dec 16, 2019

Fixes #902

$ wrangler dev -h http://localhost:8000
💁  JavaScript project found. Skipping unnecessary build!
Error: You cannot currently use wrangler dev with a local server as the host. You could use TryCloudflare to generate a public URL that you could then pass as the host to wrangler dev.
See https://developers.cloudflare.com/argo-tunnel/trycloudflare/ for more info

This approach is a bit naive at the moment, there are other endpoints that the preview service will return a rick roll embed on.

@EverlastingBugstopper EverlastingBugstopper added the feature Feature requests and suggestions label Dec 16, 2019
@EverlastingBugstopper EverlastingBugstopper added this to the dev server milestone Dec 16, 2019
@EverlastingBugstopper EverlastingBugstopper requested a review from a team December 16, 2019 23:29
@EverlastingBugstopper EverlastingBugstopper self-assigned this Dec 16, 2019
@gabbifish
Copy link
Contributor

gabbifish commented Dec 17, 2019

If we need to do this, I think we should be at parity with what capn proto checks for in restrict_peers(); just checking for localhost isn't enough.

@EverlastingBugstopper EverlastingBugstopper changed the title [dev] Disallow localhost as backend [wip] [dev] Disallow localhost as backend Jan 21, 2020
@EverlastingBugstopper EverlastingBugstopper deleted the avery/disallow-localhost branch May 7, 2020 20:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Feature requests and suggestions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants