Only update/install curl if not available

[drnic]

apt-get -y update is kinda slow to perform if not actually necessary

[goehmen]

I created https://www.pivotaltracker.com/story/show/85279614

[onsi]

sweet

[davidwadden]

drnic,

i'd like to take some time to discuss this with my team next week. there are additional apt-get installs made in the install-diego-cell script that don't depend on whether curl is already available on the system. my understanding is this script should only get run when provisioning, so since we know the base image doesn't come with curl, we'll never get the condition that curl is already installed on the system. so, at a minimum, we'd need to pull out the update from the conditional clause, and then we're not saving as much..

also, need to speak with them why we're doing the update, which just refreshes sources and repositories, rather than an upgrade, which would install the latest & greatest packages on the system.

david

[dajulia3]

The apt-get update is in the install-common script which runs on both the coordinator and the cell prior to their specific installation scripts. We don't just update to grab the latest version of curl, but of anything apt-get installed later on.

That makes me nervous not to apt-get update. We are about to work on implementing a more extensive pipeline that tests lattice in all of our currently supported infrastructures in addition to Vagrant. Once that is in place, we can try removing the update, running through the pipeline, and see if anything breaks. If nothing breaks, then we can remove that apt-get update entirely, and still conditionally install curl.

[davidwadden]

Closing this for now. We rely on running apt-get update in the install-common script to get the latest package list for subsequent apt-get install's in the install-coordinator and install-lattice-cell scripts, and it's not reliant on whether curl is installed on server or not.