Cleanup

[benlangfeld]

A few nagging issues addressed.Dear Cloud Foundry contributor,

If you are reading this message, it means you submitted a pull request in the Cloud Foundry GitHub repository.

First of all, thanks! We really appreciate your participation.

Recently we made some changes in how we are verifying and reviewing open source contributions like yours. In addition, we changed the way we can expose our internal development in real-time. The changes are exciting, as they allow all our staff to collaborate seamlessly with you, which increases our mutual velocity and gives the community a bigger stake in our direction.

The Cloud Foundry team uses Gerrit, a code review tool that originated in the Android Open Source Project. We also use GitHub as an official mirror, though all pull requests are accepted via Gerrit.

Follow these steps to make a contribution to any of our open source repositories:

1. Complete our CLA Agreement for
   individuals or
   corporations.

2. Sign up for an account on our public Gerrit server at
   http://reviews.cloudfoundry.org/.

3. Create and upload your public SSH key in your Gerrit account profile.

4. Set your name and email:

           git config --global user.name "Firstname Lastname"
           git config --global user.email "your_email@youremail.com"
   

5. Install our gerrit-cli gem:

           gem install gerrit-cli
   

6. Clone the Cloud Foundry repo:
   Note: to clone the BOSH repo, or the Documentation repo, replace
   vcap with bosh or oss-docs

           gerrit clone ssh://reviews.cloudfoundry.org:29418/vcap
           cd vcap
   

7. Make your changes, commit, and push to gerrit:

           git commit
           gerrit push
   

Once your commits are approved by our Continuous Integration Bot (CI Bot) as well as our engineering staff, return to the Gerrit interface and MERGE your changes. The merge will be replicated to GitHub automatically at https://github.com/cloudfoundry. If you get feedback on your submission, we recommend squashing your commit with the original change-id. See the squashing section here for more details: https://help.github.com/rebase.

[benlangfeld]

Might I suggest that instead of editing PR messages, you post comments. That way, I would have received a notification that this PR had been updated.

[pbozeman]

That was a bug and was fixed. Thanks.

[benlangfeld]

Unfortunately, despite adding my SSH public key to gerrit, I'm seeing a problem:

{21:53}[ruby-1.9.3]~/code/ruby ben% gerrit clone ssh://reviews.cloudfoundry.org:29418/vmc
Cloning into 'vmc'...
Permission denied (publickey).
fatal: The remote end hung up unexpectedly
ERROR: Command 'git clone ssh://reviews.cloudfoundry.org:29418/vmc ' exited with non-zero status (128).

Any ideas?