ccv3.Client : replace usages of newHTTPRequet when possible #6
Conversation
|
Hello, the PR looks ok to me. However I have a slight doubt since this means that we are diverging further from the client implementation at the upstream (cloudfoundry/cli). I think simply copying the implementations from the v7 or v8 branch would be a better solution. What do you think? |
…MakeListRequest and MakeRequestUploadAsync methods
…t and MakeListRequest methods
…keListRequest methods
gmllt
force-pushed
the
ccv3-implementations-uses-ccv3-client-make-requests
branch
from
61c25f1
to
f827354
Compare
|
@Thanhphan1147 I have updated the branch. I have copied implementations from the upstream, and extracted ressources as well. |
|
Hello, looks good to me. Thanks |
|
@sleungcy, can you take a look at this PR again (i modified it to include @Thanhphan1147's recommendations) ? |
|
@sleungcy, can you take a look at this PR again (i modified it to include @Thanhphan1147's recommandations) ? |
|
|
||
| return responseBuildpack, response.Warnings, err | ||
| return responseBody, warnings, err |
There was a problem hiding this comment.
actually wouldn't responseBody be undefined here?
There was a problem hiding this comment.
My bad, thanks for noticing it.
It should be ok now
|
I've also removed unnecessary definitions for ccv3.APILink, ccv3.APILinks and ccv3.Metadata. |
|
@loafoe can you help have a look? |
|
@gmllt if @sleungcy and @Thanhphan1147 are OK I'm fine merging this one. |
…9a5+incompatible (#549) This version of cloudfoundry-cli fixes bugs occuring when using some specifics ressources such as isolation segments. (See [ccv3.Client : replace usages of newHTTPRequet when possible #6](cloudfoundry-community/cloudfoundry-cli#6))
Description of the Change
This PR replaces usages of ccv3.Client
newHTTPRequestmethod in favor of ccv3.ClientMakeRequest,MakeListRequestandMakeRequestUploadAsyncmethods for the following ccv3.Client methods :Why Is This PR Valuable?
This PR standardize interactions with the ccv3.Client, using
MakeRequest,MakeListRequestandMakeRequestUploadAsyncfor the methods mentionned above as they are already used in others ccv3.Client methods.How Urgent Is The Change?
Those changes are not urgent but will help to get rid of a failure encountered during the entitlement of an IsolationSegment to an Organization using the cloudfoundry terraform provider (cloudfoundry-community/terraform-provider-cloudfoundry#449).