Use structs, for easier testing(?) #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shinji62 what do you think? |
|
Seems ok, but you need to rebase first before merging :) |
|
Yeah, ofc. This was just a throwaway branch for playing around anyways. |
simonjohansson
force-pushed
the
UseStructsForLoggingEvents
branch
3 times, most recently
from
8a21ef6
to
dfee94a
Compare
simonjohansson
force-pushed
the
UseStructsForLoggingEvents
branch
from
dfee94a
to
922b22d
Compare
simonjohansson
added a commit
that referenced
this pull request
May 13, 2015
…ngEvents Use structs, for easier testing(?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Want to run this trough you guys/gals out there. As pointed out by #17 we want more tests!
Instead of logging in each of the functions, create a struct instead. Then call AnnotateWithAppData() on the struct, then simply call .Log() on it.
This is a start to break out any external calls as much as possible from the logic to allow easier testing.
This also kinda addresses @mrdavidlaing comment over at #6
What do you think?