godep: switch to -copy=true #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flag -copy=false in godep will be removed. This commit switches to using 'godep save' with no flag. We don't change the version of any dependencies here, just rerun godep to include source code. See also the proposal for removing flag -copy at http://goo.gl/RpYs8e.
|
@kr not a fan of this at all. But I can understand your motivation for it and the rationale behind it. Just means I need to explore an alternative solution. I don't want to vendor my dependencies in the repo itself; I just want to be able to restore them to a known state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings, @kr here!
I'm sending this pull request because this project appears to be using
godep save -copy=false, and that flag is being retired. You can read more about why it's going away in the original proposal at http://goo.gl/RpYs8e. In short,-copy=true(the default behavior) provides a better experience for the end user, and godep will benefit from a more focused feature set.It's not hard to switch. But I figured, to make it as easy as possible I should just do it for you. 😄
The procedure used to create this patch was, essentially,
Note that this patch was generated by an automatic process, so you might want to double check that everything looks reasonable before merging.
Please don't hesitate to let me know if you have any questions or concerns.
I hope you'll consider merging this patch—your users will thank you!
💖 Thanks! 💖