Use logstash redis defaults. #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rogeruiz
reviewed
Jan 17, 2017
| if_p('redis.congestion_threshold') do |threshold| | ||
| output['options']['congestion_threshold'] = threshold | ||
| end | ||
| %> |
There was a problem hiding this comment.
72 to 87 are the changes introduced in this PR. Most of the rest is whitespace.
jmcarp
force-pushed
the
logstash-redis-defaults
branch
from
0076df1
to
a86bf56
Compare
jmcarp
force-pushed
the
logstash-redis-defaults
branch
from
a86bf56
to
5582293
Compare
jmcarp
force-pushed
the
logstash-redis-defaults
branch
from
f92f7f0
to
f5f5ed6
Compare
|
The only non-default option I saw for redis input was |
Infra-Red
approved these changes
Jan 18, 2017
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Resolves #24]
Most of the diffs here are changing tabs to spaces. The only meaningful change is dropping the default redis congestion properties, then only adding them to the redis options if defined.