Escape values from env_file #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vir2albulb
approved these changes
Sep 24, 2021
bgandon
force-pushed
the
master
branch
2 times, most recently
from
bad41f3
to
edd15a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit sanitizes the values of the
env_file. Currently the values are source'd as they are, causingoutto crash with certain envvar values (e.g., those containing double quotes, which is what happened to me), and even allowing arbitrary code injection. This PR should protect against all dangerous escape characters in Bash (",\,<backtick>,$).Thanks and keep up the good work!