use block_device_mapping_v2 instead of deprecated block_device_mapping

[dkoper]

tested successfully on Icehouse (deploying BOSH from bosh-init & CF from BOSH) (with boot_from_volume: true of course):

Using boot parms: `{:name=>"vm-5e498960-a16e-4d5c-9d7d-72fa26451306", :image_ref=>"792115dd-126a-4031-bdb0-48f3b5a41920", :flavor_ref=>"c4f75bdb-a283-4b7e-829c-ddd6f1edcf23", :key_name=>"cf-keypair2", :security_groups=>["default", "cf-private", "bosh"], :os_scheduler_hints=>nil, :nics=>[{"net_id"=>"d261123e-3d69-41b0-a74b-34af85cb677f", "v4_fixed_ip"=>"192.168.0.2"}], :config_drive=>false, :user_data=>"{\"registry\":{\"endpoint\":\"http://127.0.0.1:6901\"},\"server\":{\"name\":\"vm-5e498960-a16e-4d5c-9d7d-72fa26451306\"},\"networks\":{\"private\":{\"cloud_properties\":{\"net_id\":\"d261123e-3d69-41b0-a74b-34af85cb677f\"},\"default\":[\"dns\",\"gateway\"],\"dns\":[\"xxx\"],\"gateway\":\"192.168.0.1\",\"ip\":\"192.168.0.2\",\"netmask\":\"255.255.255.0\",\"type\":\"manual\",\"use_dhcp\":true},\"public\":{\"cloud_properties\":{},\"ip\":\"xxx\",\"type\":\"vip\",\"use_dhcp\":true}},\"dns\":{\"nameserver\":[\"137.172.74.130\"]}}", :block_device_mapping_v2=>[{:uuid=>"792115dd-126a-4031-bdb0-48f3b5a41920", :source_type=>"image", :dest_type=>"volume", :volume_size=>20480, :boot_index=>"0", :delete_on_termination=>"1", :device_name=>"/dev/vda"}]}

[cfdreddbot]

Hey dkoper!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/118725833.

[voelzmo]

Thanks @dkoper for the PR!

We don't run unit-tests automatically for each PR for now, but they are failing after your changes.

$ cd src/bosh_openstack_cpi
$ bundle install
$ bundle exec rspec spec/unit
Failed examples:

rspec ./spec/unit/create_vm_spec.rb:461 # Bosh::OpenStackCloud::Cloud create_vm when boot_from_volume is set creates an OpenStack server with a boot volume
rspec ./spec/unit/create_vm_spec.rb:506 # Bosh::OpenStackCloud::Cloud create_vm when boot_from_volume is set with a volume_type creates an OpenStack server with a boot volume

Could you please fix those? Thanks!

[voelzmo]

Thanks @kanekoh and @dkoper! We'll be pulling this in soon, you can follow the above story.