This repository has been archived by the owner on Feb 10, 2022. It is now read-only.
Add configurable login parameters #152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add configurable login parameters to pull images from custom (private) docker registries where authentication is needed. * Add properties login.name, login.password, login.server to container job and create environment variable for login parameters from these properties * Add docker login and docker pull commands to job ctl that is executed if the login properties are set
|
|
|
Stale pull request message |
|
@neil-hickey Any chance somebody could do a code review for this change? I see you recently merged some PRs, maybe you can help to identify somebody to look into this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
similar to the issue #77 and PR #104 I think that not having the option to use images from a private (i.e. login-protected) registry is quite a limitation. I tried a different, simpler approach than #104, that consists in maintaining the login information at the container job and adding a docker login and docker pull to the ctl before starting the container.
What do the maintainers think about this approach?
I gathered that there are more people trying to do this.
Change:
Add configurable login parameters to pull images from
custom (private) docker registries where authentication is
needed.
container job and create environment variable for login
parameters from these properties
is executed if the login properties are set