Use one kube service per bosh job #382

alexjh · 2018-08-13T22:23:25Z

Resolves #367

mook-as

We really should have changed the role variable names to instanceGroup :( (Not from this change, and not expected to be fixed here.)

First round comments; I'm going to need to look again (before you change anything) to look at the actual architecture...

model/roles.go

kube/service.go

model/roles.go

kube/service.go

kube/stateful_set_test.go

model/job.go

kube/service.go

mook-as

Thanks, I think I have a better understanding of what is happening now; just some relatively minor changes (some of which may require discussion first).

kube/service.go

kube/stateful_set_test.go

model/roles.go

test-assets/role-manifests/kube/bosh-run-count-configurable.yml

model/job.go

This lets us skip nil checks and iterate on empty lists instead.

mook-as suggested changes Aug 27, 2018

View reviewed changes

mook-as reviewed Aug 28, 2018

View reviewed changes

kube/service.go Outdated Show resolved Hide resolved

mook-as approved these changes Aug 29, 2018

View reviewed changes

andreas-kupries mentioned this pull request Aug 30, 2018

Add PSP support #389

Merged

alexjh force-pushed the alexh/one-kube-service-per-bosh-job branch from f453dc8 to 345c29a Compare August 31, 2018 18:23

viovanov changed the base branch from master to develop September 6, 2018 22:00

Alex Harford added 16 commits September 6, 2018 15:10

Add job properties to role manifest

16fb1a2

Job names are included in tests now

6ef732f

Headless services generate internal services now

e2fc283

Handle case where no opinions are defined

0bba2cb

StatefulSets need scaling defined

fe755dd

Hostnames can't have _

90fbc26

Group port definitions by statefulset, not service

722ba5d

Restore creation of service based only on role

b6066d8

Restructure container properties to avoid pointers

63099a7

This lets us skip nil checks and iterate on empty lists instead.

Add doc line to createPort()

be7434d

Clarify newService / newGenericService

f3b3767

Added check for instance group service

fc28eca

Use ConvertNameToKey to transform job, role names

0caecf1

Refactor createPorts() to clarify usage

12dcafa

Update assert text

5276e51

Use clearer name for newClusteringService()

1615af7

alexjh force-pushed the alexh/one-kube-service-per-bosh-job branch from 345c29a to 1615af7 Compare September 6, 2018 22:10

mook-as merged commit 2b74e2b into develop Sep 6, 2018

mook-as deleted the alexh/one-kube-service-per-bosh-job branch September 6, 2018 22:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use one kube service per bosh job #382

Use one kube service per bosh job #382

alexjh commented Aug 13, 2018 •

edited

mook-as left a comment

mook-as left a comment

Use one kube service per bosh job #382

Use one kube service per bosh job #382

Conversation

alexjh commented Aug 13, 2018 • edited

mook-as left a comment

Choose a reason for hiding this comment

mook-as left a comment

Choose a reason for hiding this comment

alexjh commented Aug 13, 2018 •

edited