HTTP proxy for kube-controller-manager

[MatthiasWinzeler]

Hi guys

We need to set http_proxy (and no_proxy) for the kube-controller-manager binary.
Use case: kube-controller-manager talks to external systems (i.e. to the Cloud API for storage provision) which are behind a proxy in our environment.

This is currently not possible with the BOSH release - we'd like to add this config item to the release.

This basically means to add export http_proxy=<%= p('http_proxy') %> (and no_proxy) before launching the binary in kubernetes_controller_manager_ctl.

Before I create a PR I have some questions:

• Would you welcome it?
• For which jobs shall we expose the proxy? We only need it for the kube-controller-manager job, however, for consistency, it should probably be added for all jobs that interact with external systems
• Shall I also create a PR for kubo-deployment? If yes, should I reuse the already existing env.http_proxy that is used for BOSH?

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/152849807

The labels on this github issue will be updated when the story is started.

[glestaris]

hey @MatthiasWinzeler. Your use case and proposed PR sound very reasonable. Please proceed and we will be happy to review/merge.

[MatthiasWinzeler]

hi @glestaris
created the PR #130
We figured out that not only the kubernetes-controller-manager interacts with the cloud provider, but other jobs also do.

Disclaimer: The PR is just a quick & dirty way to get it running for us, it probably needs some polishing - let's consider it a discussion basis :)

Also, these vars need to be exposed in kubo-deployment as well, but we can create a PR there if this is merged.
Thank you!

[glestaris]

#130 is merged.