New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP proxy support for cloud provider interactions #130

Closed
wants to merge 11 commits into
base: master
from

Conversation

Projects
None yet
10 participants
@MatthiasWinzeler
Contributor

MatthiasWinzeler commented Nov 24, 2017

As discussed in #126

@cfdreddbot

This comment has been minimized.

cfdreddbot commented Nov 24, 2017

Hey MatthiasWinzeler!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot

This comment has been minimized.

cf-gitbot commented Nov 24, 2017

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/153135793

The labels on this github issue will be updated when the story is started.

scis-taawima0 and others added some commits Nov 28, 2017

BenChapman and others added some commits Dec 11, 2017

@glestaris

This comment has been minimized.

Member

glestaris commented Jan 26, 2018

hey @MatthiasWinzeler, sorry for dropping the ball on this.

Why is the kubelet-password property exposed?

@glestaris

This comment has been minimized.

Member

glestaris commented Jan 26, 2018

@MatthiasWinzeler

This comment has been minimized.

Contributor

MatthiasWinzeler commented Jan 26, 2018

@glestaris looks like kubelet-password came with this merge afterwards: 45f41af
It's not related to the PR and probably can be removed...

I think it's fine to also expose https_proxy. For us, it was not needed, since http_proxy also applies to https urls (golang's default behavior).

@glestaris

This comment has been minimized.

Member

glestaris commented Jan 26, 2018

👍 thanks, we will look into merging this soon

@cf-gitbot cf-gitbot added in progress and removed scheduled labels Jan 30, 2018

@ryanjjones10

This comment has been minimized.

ryanjjones10 commented Jan 30, 2018

As an update, this is top of backlog for CFCR and is expected to be in the next release, 0.14. This is not expected to be in PKS 1.0 but will be added shortly after to one of the alphas if you all are interested in taking those in.

akshaymankar added a commit that referenced this pull request Feb 1, 2018

Changes from the PR and tests for templates
[#153135793] [#130]

Signed-off-by: Shash Reddy <sreddy@pivotal.io>

shashwathi added a commit that referenced this pull request Feb 1, 2018

Changes from the PR and tests for templates
[#153135793] [#130]

Signed-off-by: Shash Reddy <sreddy@pivotal.io>

@cf-gitbot cf-gitbot added delivered and removed in progress labels Feb 5, 2018

@glestaris

This comment has been minimized.

Member

glestaris commented Feb 5, 2018

@MatthiasWinzeler the commits are merged. I am closing the PR.

@glestaris glestaris closed this Feb 5, 2018

@cf-gitbot cf-gitbot added accepted and removed delivered labels Feb 5, 2018

@MatthiasWinzeler

This comment has been minimized.

Contributor

MatthiasWinzeler commented Feb 5, 2018

@glestaris great news, thank you!

@akshaymankar

This comment has been minimized.

Member

akshaymankar commented Feb 6, 2018

Thanks for your help with the no_proxy thing @MatthiasWinzeler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment