Skip to content
This repository has been archived by the owner on Feb 10, 2022. It is now read-only.

HTTP proxy support for cloud provider interactions #130

Conversation

MatthiasWinzeler
Copy link
Contributor

As discussed in #126

@cfdreddbot
Copy link

Hey MatthiasWinzeler!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/153135793

The labels on this github issue will be updated when the story is started.

@glestaris
Copy link

hey @MatthiasWinzeler, sorry for dropping the ball on this.

Why is the kubelet-password property exposed?

@glestaris
Copy link

@MatthiasWinzeler
Copy link
Contributor Author

@glestaris looks like kubelet-password came with this merge afterwards: 45f41af
It's not related to the PR and probably can be removed...

I think it's fine to also expose https_proxy. For us, it was not needed, since http_proxy also applies to https urls (golang's default behavior).

@glestaris
Copy link

👍 thanks, we will look into merging this soon

@ryanjjones10
Copy link

As an update, this is top of backlog for CFCR and is expected to be in the next release, 0.14. This is not expected to be in PKS 1.0 but will be added shortly after to one of the alphas if you all are interested in taking those in.

akshaymankar pushed a commit that referenced this pull request Feb 1, 2018
[#153135793] [#130]

Signed-off-by: Shash Reddy <sreddy@pivotal.io>
shashwathi pushed a commit that referenced this pull request Feb 1, 2018
[#153135793] [#130]

Signed-off-by: Shash Reddy <sreddy@pivotal.io>
@glestaris
Copy link

@MatthiasWinzeler the commits are merged. I am closing the PR.

@MatthiasWinzeler
Copy link
Contributor Author

@glestaris great news, thank you!

@akshaymankar
Copy link
Contributor

Thanks for your help with the no_proxy thing @MatthiasWinzeler

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants