Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow operators to control feature gates #201

Merged
merged 3 commits into from Apr 30, 2018

Conversation

@bsnchan
Copy link
Contributor

@bsnchan bsnchan commented Apr 27, 2018

bsnchan and others added 2 commits Apr 27, 2018
Signed-off-by: Dave Protasowski <dprotaso@gmail.com>
@cfdreddbot
Copy link

@cfdreddbot cfdreddbot commented Apr 27, 2018

Hey bsnchan!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot
Copy link

@cf-gitbot cf-gitbot commented Apr 27, 2018

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/157161612

The labels on this github issue will be updated when the story is started.

@tvs
tvs approved these changes Apr 27, 2018
Copy link
Member

@tvs tvs left a comment

This can be very useful. I suppose it's possible that the operator could use this to disable a feature that defaults to on and that we rely on, but given that there are so many other ways to break the cluster (e.g. configuring wonky certs), I'm not sure that matters.

@bsnchan
Copy link
Contributor Author

@bsnchan bsnchan commented Apr 30, 2018

@glestaris any thoughts about this? Some of the features we wanted to try out are CustomResourceValidation and CustomResourceSubresources.

@SemanticallyNull SemanticallyNull merged commit df24873 into cloudfoundry-incubator:master Apr 30, 2018
1 check passed
1 check passed
concourse-ci/status Concourse CI build success
Details
@cf-gitbot cf-gitbot added delivered and removed in progress labels Apr 30, 2018
@cf-gitbot cf-gitbot added accepted and removed delivered labels May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants