This repository has been archived by the owner on Feb 10, 2022. It is now read-only.
Remove bosh spec property Labels as it conflicts with k8s-args node-labels property.
#305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Preference k8s-args setting flags over bosh specs * End users who used k8s-args to set labels would be broken
|
✅ Hey henderjm! The commit authors and yourself have already signed the CLA. |
|
lgtm |
cf-gitbot
added
in progress
delivered
accepted
and removed
in progress
delivered
accepted
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Remove confusion between k8s-args
node-labelsand bosh specLabels. It is expected that we can use k8s-args to set flags for kubelet rather than using bosh spec flags. This PR preferences using k8s-args.How can this PR be verified?
CI
Is there any change in kubo-deployment?
No
Is there any change in kubo-ci?
Yes, will add PR to add integration test for Labels
Does this affect upgrade, or is there any migration required?
Yes, people who have used Labels in the past will need to move their custom labels to be
Which issue(s) this PR fixes:
Release note: