Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

Add additional annotations feature in quarks-job #79

Merged
merged 2 commits into from
Apr 30, 2020

Conversation

rohitsakala
Copy link
Contributor

@rohitsakala rohitsakala commented Apr 28, 2020

@rohitsakala rohitsakala force-pushed the rohit/annotation branch 3 times, most recently from d0075d3 to 3f04100 Compare April 28, 2020 11:51
@rohitsakala rohitsakala changed the title Update to latest quarks-utils package Add additional annotations feature in quarks-job Apr 28, 2020
@rohitsakala rohitsakala force-pushed the rohit/annotation branch 2 times, most recently from 8d65901 to a47bd7a Compare April 28, 2020 13:03
@manno
Copy link
Member

manno commented Apr 29, 2020

Is this PR necessary for cloudfoundry-incubator/quarks-operator#909
It adds additional annotations, just like additional labels?

@rohitsakala
Copy link
Contributor Author

Is this PR necessary for cloudfoundry-incubator/cf-operator#909
It adds additional annotations, just like additional labels?

Yes, this is required because now quarks link secrets use restart annotation for updating all referenced consumers such as deployment or statefulset.

@rohitsakala rohitsakala merged commit a211629 into master Apr 30, 2020
@rohitsakala rohitsakala deleted the rohit/annotation branch April 30, 2020 13:44
rohitsakala added a commit that referenced this pull request May 11, 2020
rohitsakala added a commit that referenced this pull request May 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants