Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enablement for oci-phase-1 configuration in CC #23

Closed
wants to merge 1 commit into from

Conversation

BooleanCat
Copy link

Change rootfs column size to 1024. Diego's desired_lrp table, column roofs has width 255, which is too short to fit an OCI URI that looks like:

preloaded+layer:cflinuxfs2?layer=https://cloud-controller-ng.service.cf.internal:9023/internal/v4/droplets/3f53478e-d606-4380-a248-1b64ec930edd/753660e34a49c5985dd544ab184a990c1d27d3a996a13220c8a3bc8c9393e191/download&layer_path=/home/vcap&layer_digest=753660e34a49c5985dd544ab184a990c1d27d3a996a13220c8a3bc8c9393e191

[#149234807]

Tracker: https://www.pivotaltracker.com/story/show/149234807

Signed-off-by: Tom Godkin tgodkin@pivotal.io
Signed-off-by: Ed King eking@pivotal.io
Signed-off-by: Craig Furman cfurman@pivotal.io

[#149234807]

Signed-off-by: Tom Godkin <tgodkin@pivotal.io>
Signed-off-by: Ed King <eking@pivotal.io>
Signed-off-by: Craig Furman <cfurman@pivotal.io>
@cfdreddbot
Copy link

Hey BooleanCat!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/150165898

The labels on this github issue will be updated when the story is started.

@emalm
Copy link
Member

emalm commented Aug 11, 2017

Thanks, @BooleanCat! Is there any other work you have in mind that would necessitate an even larger size to the rootfs column? I see that that URL is 317 characters in total, so the URLs of this form would fit into that new 1024 comfortably.

Best,
Eric

@BooleanCat
Copy link
Author

We are still building out oci compatibility within garden/grootfs and there's a possibility that we might need to put more stuff in this URL later as we learn more.

A size of 1024 somewhat future proofs us against that possibility.

@emalm
Copy link
Member

emalm commented Sep 19, 2017

Merged via 7699bb2.

@emalm emalm closed this Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants