Windows doesn't allow renaming files that are open (attempt 2) #171
Conversation
Update to latest develop
Update to latest develp
…ith OS specific separator
|
Hey Fydon! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Fydon
force-pushed
the
feature/AddWindowsSupport3
branch
from
b55d060
to
f78baee
Compare
|
@Fydon will pull it in. |
| ) | ||
|
|
||
| BeforeEach(func() { | ||
| tempDownloadFile, err := ioutil.TempFile("", "temp-download-file") |
There was a problem hiding this comment.
does this test fail on windows if not changed to have 3 temp files?
There was a problem hiding this comment.
This test fails everywhere now without 3 temp files, as the file is being closed on each retry. The real file system is creating a new temp file on each of the 3 retries, but the test was previously only using one temp file for all retries.
| @@ -244,6 +244,8 @@ func (d FSBlobsDir) TrackBlob(path string, src io.ReadCloser) (Blob, error) { | |||
|
|
|||
| blobs[idx] = Blob{Path: path, Size: fileInfo.Size(), SHA1: sha1} | |||
|
|
|||
| tempFile.Close() | |||
There was a problem hiding this comment.
any chance for a test for this one? nothing currently fails?
There was a problem hiding this comment.
Sure, but what should that test do? This method does defer the close of the temp file, but now the defer close will fail if this line is reached. The defer close isn't checking for failure, so this close is causing a silent failure, but also preventing an error in Windows environments.
|
@cppforlife Should there be a defer close in Should I make defer close execute where I've added close? It seems that I could do this by splitting part of the function into another function or using embedded functions. The reason I ask this is that it might be confusing to have two close calls in the same function for the same resource, i.e. defer close and close. |
This is a replacement for #121. All the tests now pass and the changes have been rebased to a recent version of the develop branch.