Remove PowerDNS dependent --dns flag and related functionality
#644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 20, 2024
aramprice
changed the title
--dns flang and related functionality--dns flag and related functionality
aramprice
force-pushed
the
remove-powerdns
branch
from
3c89f42
to
425670d
Compare
jpalermo
requested review from
a team,
lnguyen and
bgandon
and removed request for
a team
ystros
reviewed
Mar 22, 2024
aramprice
force-pushed
the
remove-powerdns
branch
from
425670d
to
56ba9e0
Compare
PowerDNS is being removed from the BOSH Director, and as a consequence the data returned from the `instances` and `vms` commands no longer have DNS data returned. This commit removes the `--dns` flag and logic to display the data returnd when it is sent. Add a spec to validate that the CLI continues to handle responses from directors which still have PowerDNS code. Concretely this means the VM info response has a `"dns"` key in it. See: cloudfoundry/bosh#2501
aramprice
force-pushed
the
remove-powerdns
branch
from
56ba9e0
to
fb08fb4
Compare
ystros
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PowerDNS is being removed from the BOSH Director, and as a consequence the data returned from the
instancesandvmscommands no longer have DNS data returned.This commit removes the
--dnsflag and logic to display the data returnd when it is sent.See: cloudfoundry/bosh#2501