Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow white-space in (( var_name )) template #653

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

nouseforaname
Copy link
Contributor

currently

bosh int <( echo "test: (( var_name ))") --v=var_name=value will render

test: (( var_name ))

with the provided patch it will render:

test: value

I guess this behavior has been the same forever and this is not strictly required. I just happened to lose 20 minutes of my life trying to figure out why my interpolation didn't work and figured I'd at least try to create a commit.

currently

`bosh int <( echo "test: (( var_name ))")  --v=var_name=value` will render

```
test: (( var_name ))
```

with the provided patch it will render:

```
test: value
```

I guess this behavior has been the same forever and this is not strictly required. I just
happened to lose 20 minutes of my life trying to figure out why my interpolation didn't work
and figured I'd at least try to create a commit.
@nouseforaname nouseforaname force-pushed the improvement-allow-interpolation-with-whitespace branch from 9031c36 to 55cc5bc Compare May 31, 2024 13:37
Copy link
Member

@aramprice aramprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a reasonable change though I'm not super familiar with the templating code...

@jpalermo jpalermo merged commit c5662d1 into main Jun 6, 2024
5 checks passed
@jpalermo jpalermo deleted the improvement-allow-interpolation-with-whitespace branch June 6, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants