Implement calculate_vm_cloud_properties CPI method
#56
Conversation
- This method will allow BOSH to make cpu, ram, and ephemeral_disk first class VM properties rather than IaaS-specific cloud_props
- E.g. `vm_types.cloud_properties.flavor` can now be replaced with `vm_types.{cpu,ram,ephemeral_disk}` in your manifest
- Allows for greater manifest portability between IaaS
- BOSH will take the result of calculate_vm_cloud_properties, merge it with various manifest cloud_properties (e.g. vm_type), then pass it all to create_vm
- Only tricky bit was handling of ephemeral disks, see "In the case where no ephemeral disk is large enough" comment in code
[#126023557](https://www.pivotaltracker.com/story/show/126023557)
Signed-off-by: Lyle Franklin <lfranklin@pivotal.io>
|
Hey ljfranklin! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/136077959 The labels on this github issue will be updated when the story is started. |
|
Hello @voelzmo and SAP gang! While there's no real rush to merge this as the |
|
Hey @cdutra we're in the process of rebasing and merging this in. I guess if there's something to do from your side, we'll ping you. Stay tuned! :) |
|
@cdutra We merged locally to run the integration tests against an OpenStack on our side. Today we had a deeper look at the code and have no complains. Thanks for the work! |
|
@cdutra @ljfranklin just for your information: We changed the behavior a bit regarding boot_from_volume. It is required to use a flavor with ephemeral disk size 0 when using boot_from_volume. Otherwise ephemeral disk is attached from hypervisor-local storage. |
vm_types.cloud_properties.flavorcan now be replaced withvm_types.{cpu,ram,ephemeral_disk}in your manifest#126023557
Signed-off-by: Lyle Franklin lfranklin@pivotal.io