De-duplicate NSX security groups #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Hey EleanorRigby! The commit authors and yourself have already signed the CLA. |
nehagjain15
reviewed
Dec 6, 2018
EleanorRigby
force-pushed
the
ta-securityGroups
branch
3 times, most recently
from
24dd561
to
c1be442
Compare
EleanorRigby
changed the title
|
@nehagjain15 : Can you review it once more? |
nehagjain15
reviewed
Dec 12, 2018
nehagjain15
reviewed
Dec 12, 2018
nehagjain15
reviewed
Dec 12, 2018
EleanorRigby
force-pushed
the
ta-securityGroups
branch
from
2e3919a
to
640cc24
Compare
- Add error code 311 to VM-belongs-to-NSX-Security group check - Add unit tests
Performance improvement by ignoring all computation if nsxv config is not specified in global configuration. As a result if there is no global config for nsxv , all nsxv related config in cloud config is skipped without raising any error.
EleanorRigby
force-pushed
the
ta-securityGroups
branch
from
640cc24
to
29b154c
Compare
EleanorRigby
dismissed
nehagjain15’s stale review
Test refactoring is done to sufficient levels. NSX-V is getting obsolete amongst our user and can do with less refactoring (in favor of more important feature development).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Security groups for NSX-V has multiple sources
We need to gather all
nsx-security-groupsand deduplicate before calling API to add vm to thesensx-security-groups. It saves execution time. More robust code as we do not need to rely on some fragile logic to not raise error if return code is 203 (vmalready exists in Security group).The issue is caused when upgrading from NSX-V 6.3.x to 6.4.2.
6.4.2 NSX manager's security group API return code is different from 6.3.x
Related PR and Issues
Fixes issue
Object vm-32660 is already a member of Security5.Impacted Areas in Application
Adding NSX-Security groups
Type of change