New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a bosh user, I'd like to filter addon installation based on the type of a VM: errand, service, compilation #1833
Comments
@voelzmo interesting idea |
@voelzmo can you please add examples of each type of colocation you have in mind? |
Ah, sorry, I completely missed this, thanks for the reminder.
|
@cppforlife @dpb587-pivotal opinions about the use-cases? |
The include-compilation use cases sound a bit weird - both of those use cases sound racy to me. There's no guarantee the addons may have finished scanning by the time compilation was finished. For completeness though, I think it might make sense regardless. |
Ah, good point. I guess you’d also come up with cases where you want to exclude those scanning tools from compilation VMs then.
I guess what I was looking for with the compilation cases above was something similar to multi buildpacks where I can include some scanning tool before my actual code is compiled. Thanks for the race condition reminder.
On 21. Dec 2017, at 07:49, Danny Berger <notifications@github.com<mailto:notifications@github.com>> wrote:
The include-compilation use cases sound a bit weird - both of those use cases sound racy to me. There's no guarantee the addons may have finished scanning by the time compilation was finished. For completeness though, I think it might make sense regardless.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1833 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ACJv99sR5GMd7QE6Wv3XCADbTzALCoKmks5tCf-IgaJpZM4QbAio>.
|
story to address errands at least: https://www.pivotaltracker.com/story/show/155197799 |
Pull request for lifecycle filtering: #1902 |
Awesome, thanks!
From: Danny Berger <notifications@github.com>
Reply-To: cloudfoundry/bosh <reply@reply.github.com>
Date: Thursday, 8. March 2018 at 21:29
To: cloudfoundry/bosh <bosh@noreply.github.com>
Cc: "Voelz, Marco" <marco.voelz@sap.com>, Mention <mention@noreply.github.com>
Subject: Re: [cloudfoundry/bosh] As a bosh user, I'd like to filter addon installation based on the type of a VM: errand, service, compilation (#1833)
Pull request for lifecycle filtering: #1902<#1902>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1833 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ACJv91E_OO2ELmJNq3h6dq7ReeCmIMO5ks5tcZSqgaJpZM4QbAio>.
|
This has been implemented as of #1902 |
Some addons shouldn't be installed on certain types of VMs or should only be installed on certain types. So, in my runtime config and manifest filter for addon installation, I'd like to do this based on a VM's type. Types I'd like to distinguish: errand, service, compilation. Wdyt?
The text was updated successfully, but these errors were encountered: