Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a bosh user, I'd like to filter addon installation based on the type of a VM: errand, service, compilation #1833

Closed
voelzmo opened this issue Nov 12, 2017 · 11 comments
Labels

Comments

@voelzmo
Copy link
Contributor

voelzmo commented Nov 12, 2017

Some addons shouldn't be installed on certain types of VMs or should only be installed on certain types. So, in my runtime config and manifest filter for addon installation, I'd like to do this based on a VM's type. Types I'd like to distinguish: errand, service, compilation. Wdyt?

@pivotal-jamil-shamy
Copy link
Contributor

@voelzmo interesting idea
One comment though: Maybe it can be renamed to be filter by instance type rather than VM type, so that it will not be mistaken for VM types defined in the cloud config(s), wdyt ?

@dpb587-pivotal
Copy link
Contributor

Related: #1613

@voelzmo do you have an example of a release type which should be installed on compilation vms?

@cppforlife
Copy link
Contributor

@voelzmo can you please add examples of each type of colocation you have in mind?

@voelzmo
Copy link
Contributor Author

voelzmo commented Nov 24, 2017

Ah, sorry, I completely missed this, thanks for the reminder.

  • compilation VMs:
    • e.g. Virus scan. I only want virus scanning for sources and their dependencies, don't need Virus scanning during runtime (be is long-lived service or short-lived errands)
    • I'm also thinking about some license or CVE scan that could enforce that nobody installs stuff that doesn't match company policy. There are also other means to achieve this, if you e.g. limit the location from which you can install bosh-releases (i.e. only company-vetted releases are available)
  • Service VMs:
    • Something like Turbulence or log-forwarding agents. I don't need those (or in a very different configuration) for compilation VMs or errands
  • Errand VMs:
    • Not sure what those VMs specifically need. It seems to me, that they would not need most of the stuff I'd like to install on the other two types of VMs.

@voelzmo
Copy link
Contributor Author

voelzmo commented Dec 13, 2017

@cppforlife @dpb587-pivotal opinions about the use-cases?

@dpb587-pivotal
Copy link
Contributor

The include-compilation use cases sound a bit weird - both of those use cases sound racy to me. There's no guarantee the addons may have finished scanning by the time compilation was finished. For completeness though, I think it might make sense regardless.

@voelzmo
Copy link
Contributor Author

voelzmo commented Dec 21, 2017 via email

@cppforlife
Copy link
Contributor

story to address errands at least: https://www.pivotaltracker.com/story/show/155197799

@dpb587-pivotal
Copy link
Contributor

Pull request for lifecycle filtering: #1902

@voelzmo
Copy link
Contributor Author

voelzmo commented Mar 9, 2018 via email

@jfmyers9
Copy link
Contributor

This has been implemented as of #1902

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants