Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved the deployer cann't connect to agent error[Fixed Issue#159] #160

Closed
wants to merge 4 commits into from
Closed

Resolved the deployer cann't connect to agent error[Fixed Issue#159] #160

wants to merge 4 commits into from

Conversation

tiewei
Copy link

@tiewei tiewei commented May 8, 2013

When do deploy micro bosh, there is a deadlock between agent running in
stemcell vm and deployer.

So, I adjusted the sequence of the deployer process in order that
deployer could create & attach volume to stemcell vm first and then
waiting for agent done.

Also we can change the process in agent, but because of agent is
builded in stemcell image, I think it's not a graceful way considering
compatibility

issue detailis are in #159

When do deploy micro bosh, there is a deadlock between agent running in
stemcell vm and deployer.

So, I adjusted the sequence of the deployer process in order that
deployer could create & attach volume to stemcell vm first and then
waiting for agent done.

Also we can change the process in agent, but because of agent is
builded in stemcell image, I think it's not a graceful way considering
compatibility

issue detailis are in #159
@jbayer
Copy link

jbayer commented May 8, 2013

We received the CLA agreement for Wei Tie and it is now on-file with the project, so any contributions from him may proceed.

@ajackson
Copy link
Contributor

ajackson commented May 9, 2013

Hi TieWie,
Can you please address the travis test failure before we can proceed on this pull request. Thanks.

tiewei added 2 commits May 9, 2013 18:30
Merge Codes from cloudfoundry/bosh master
The mount disk operation should not be retried, which is not like the
agent.ping operation.
And this adjustment will ensure the @deployer.renderer.index == total
== 11( a retriable step will make this value can't be count)
@tiewei
Copy link
Author

tiewei commented May 10, 2013

Hi @ajackson ,
Thank you for response, today I did 2 commits, one just merge my code with cloudfoundry/bosh master, the other did a adjustment with my code.
Now it can pass the travis test, please review.

@tiewei
Copy link
Author

tiewei commented May 14, 2013

In #159 Ferran and I found out my mistake of the execution sequence, I dead lock is not exist, close the pull request

@tiewei tiewei closed this May 14, 2013
@tiewei tiewei deleted the resolve-deployer-connect-agent-failed-issue branch May 14, 2013 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants