Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to manually install pg gem #757

Closed
wants to merge 1 commit into from

Conversation

voelzmo
Copy link
Contributor

@voelzmo voelzmo commented Feb 20, 2015

bundler does a pretty good job doing that once postgresql is installed

bundler does a pretty good job doing that once postgresql is installed
@cfdreddbot
Copy link

Hey voelzmo!

Thanks for submitting this pull request!

All pull request authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

@karlkfi
Copy link
Contributor

karlkfi commented Feb 20, 2015

I was having trouble getting bosh to bundle correctly on ruby 2.1.2 today until after manually installing pg. But I didn't seem to need it after upgrading to ruby 2.1.5.

Which version did you try on?

@voelzmo
Copy link
Contributor Author

voelzmo commented Feb 20, 2015

I was also confused that I didn't have to install the pg gem and specify the architecture manually anymore - when I wrote the initial version of this setup guide I needed to do this. My current ruby version is 2.1.5 as well, so there this seems not to be an issue.

So shall we keep this in with the hint for people on ruby <2.1.5?

@bosh-ci-push-pull
Copy link

It'd be nice to know which version of ruby fixes the issue so we can be
more explicit.

IIRC our tests in docker are running on 1.9.3 and 2.1.3. We'll probably
want to upgrade our CI before we say we officially support 2.1.5.

-Karl

On Thursday, February 19, 2015, Marco Voelz notifications@github.com
wrote:

I was also confused that I didn't have to install the pg gem and specify
the architecture manually anymore - when I wrote the initial version of
this setup guide I needed to do this. My current ruby version is 2.1.5 as
well, so there this seems not to be an issue.

So shall we keep this in with the hint for people on ruby <2.1.5?


Reply to this email directly or view it on GitHub
#757 (comment).

@karlkfi
Copy link
Contributor

karlkfi commented Feb 20, 2015

It looks like 2.1.4 is included in the bosh release as of November: 2b24dc1#diff-dac5e3e96b99077502f016c9dbb90af0

But the CLI is being tested with 1.9.3 & 2.1.2: https://github.com/cloudfoundry/bosh/blob/master/gocd/docker/install-ruby.sh

We've tried bundling without manually installing pg on fresh installs of ruby 1.9.3, 2.1.2, 2.1.3, & 2.1.5. None of them seemed to fail.

We updated the docs to be a bit more detailed and made that step optional: https://github.com/cloudfoundry/bosh/blob/develop/docs/workstation_setup.md

@karlkfi karlkfi closed this Feb 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants