Add .bin to integration test PATH.

[robdimsdale]

• Without this, we actually use the system CF CLI which may be a different version than we expect.

[robdimsdale]

Hmm, actually it seems like direnv / .envrc solves this issue locally (my issues were that I was cloning the repo for the first time).

I'll check if direnv also runs in CI, and if so this PR can be deleted.

[robdimsdale]

@ryanmoran I can't see anywhere in the Dockerfile or any task executable in https://github.com/cloudfoundry/buildpacks-ci where we set the PATH to include the cf binary that each buildpack installs. This happens with direnv via .envrc but I don't see that being executed in CI.

Am I missing something?

For context, the reason for doing this is I want to start the process of updating the CF CLI in each buildpack's integration tests to v7, but I'd rather do this change for one buildpack at a time. Therefore we need to respect the version of cf that each buildpack installs, rather than relying on the system CLI.

[sophiewigmore]

@robdimsdale I might be wrong but I noticed that in the buildpack.yml.erb template for buildpacks-ci, we run a task called update-libbuildpack. This task runs source .envrc in the buildpack directory. The task output is the buildpack, and it's used as an input for our tests so I'm assuming that's where it gets run.

[robdimsdale]

Thanks for pointing that out. It's a little hard to tell from the pipeline templates, but it looks like the update-libbuildpack task is the only place we source .envrc. At least, that's the only reference I can find when I search this repo.

It looks like that task is skipping the integration tests (and brats) - and the intention of this PR is to ensure that we use the CF CLI that we install during the integration tests.

Please let me know if I'm missing something though! Also, I'm 100% open to modifying this PR to source .envrc instead of explicitly setting the PATH.

[ryanmoran]

Is this not covered by this?

buildpacks-github-config/buildpack/scripts/.util/tools.sh

Lines 10 to 18 in f343bd3

	function util::tools::path::export() {
	local dir
	dir="${1}"
	if ! echo "${PATH}" | grep -q "${dir}"; then
	PATH="${dir}:$PATH"
	export PATH
	fi
	}

That is called when the ./scripts/integration.sh invokes the util::tools::cf::install helper function:

buildpacks-github-config/buildpack/scripts/.util/tools.sh

Line 135 in f343bd3

util::tools::path::export "${dir}"

[robdimsdale]

Great. I think that was what I was looking for. I'll close this PR and open another with my follow-on questions.