Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrectly gitignore'd vendor files for HTTP/2 #479

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Fix incorrectly gitignore'd vendor files for HTTP/2 #479

merged 1 commit into from
Sep 14, 2021

Commits on Sep 13, 2021

  1. Fix incorrectly gitignored vendor files for HTTP/2 

    - The gitignore files for the http2 and grpc assets were ignoring the
compiled binary names, which happened to collide with the names of
vendored golang modules.
- Because the gitignore files are applied recursively, git was ignoring
these modules, which meant the apps did not work unless you ran `go mod
vendor` before pushing
- We updated the gitignore files to only apply to the compiled binary
files in the sample apps' root directories

[cloudfoundy/routing-release#200]

Co-authored-by: Merric de Launey <mdelauney@vmware.com>
    @Gerg @MerricdeLauney
    Gerg and MerricdeLauney committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    5d15018 View commit details
    Browse the repository at this point in the history