Fix incorrectly gitignore'd vendor files for HTTP/2 #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The gitignore files for the http2 and grpc assets were ignoring the compiled binary names, which happened to collide with the names of vendored golang modules. - Because the gitignore files are applied recursively, git was ignoring these modules, which meant the apps did not work unless you ran `go mod vendor` before pushing - We updated the gitignore files to only apply to the compiled binary files in the sample apps' root directories [cloudfoundy/routing-release#200] Co-authored-by: Merric de Launey <mdelauney@vmware.com>
5 tasks
|
Thanks @Gerg! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
compiled binary names, which happened to collide with the names of
vendored golang modules.
these modules, which meant the apps did not work unless you ran
go mod vendorbefore pushingfiles in the sample apps' root directories
Please provide contextual information.
Root issue: cloudfoundy/routing-release#200
Previous PR: #473
What version of cf-deployment have you run this cf-acceptance-test change against?
v16.23.0
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?
N/A
How should this change be described in cf-acceptance-tests release notes?
N/A
How many more (or fewer) seconds of runtime will this change introduce to CATs?
N/A
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
@MerricdeLauney