Skip the memory resources test on K8s #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- cf-for-k8s times out instead of generating the appropriate error message Co-authored-by: Andrew Wittrock <awittrock@vmware.com> Co-authored-by: Andrew Costa <ancosta@vmware.com>
- these are used to test changes to cf-smoke-tests-release
tcdowney
approved these changes
Apr 5, 2022
tcdowney
reviewed
Apr 5, 2022
| @@ -229,6 +229,9 @@ jobs: | |||
| OPS_FILES: | | |||
| operations/use-compiled-releases.yml | |||
| operations/use-internal-lookup-for-route-services.yml | |||
| operations/windows2019-cell.yml | |||
There was a problem hiding this comment.
I didn't mean to include the pipeline changes in this PR. 😞
I switched the cf-smoke-tests-release pipeline to use the same environment for testing and that testing needs windows cells.
There was a problem hiding this comment.
I don't follow.. if you didn't mean to include these pipeline changes why not remove them before merging this PR?
There was a problem hiding this comment.
I did mean to commit them. I just forgot to switch branch before doing so. IMHO, it wasn't important enough to update this PR and then create another PR with the CI change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
This PR updates the memory resource scaling test to be skipped when the
infrastructureconfig option is set toKubernetes.Please provide contextual information.
This test fails often but is not worth changing now that cf-for-k8s is not under active development.
What version of cf-deployment have you run this cf-acceptance-test change against?
N/A
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
How should this change be described in cf-acceptance-tests release notes?
Skip the memory resource scaling test when the
infrastructureconfig option is set toKubernetes.How many more (or fewer) seconds of runtime will this change introduce to CATs?
N/A
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
@acosta11 @Birdrock @ctlong