Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip the memory resources test on K8s #522

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Skip the memory resources test on K8s #522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
980b81e
Skip the memory resources test on K8s
davewalter Apr 5, 2022
0ab5c48
CI: Upate deploy-cf to add Windows cells
davewalter Apr 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apps/instance_reporting.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ import (

var _ = AppsDescribe("Getting instance information", func() {
Describe("scaling memory", func() {
SkipOnK8s("CF-for-K8s generates a timeout instead of the expected error message")

var appName string
var runawayTestSetup *workflowhelpers.ReproducibleTestSuiteSetup

Expand Down
3 changes: 3 additions & 0 deletions ci/pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,9 @@ jobs:
OPS_FILES: |
operations/use-compiled-releases.yml
operations/use-internal-lookup-for-route-services.yml
operations/windows2019-cell.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these changes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't mean to include the pipeline changes in this PR. 😞

I switched the cf-smoke-tests-release pipeline to use the same environment for testing and that testing needs windows cells.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't follow.. if you didn't mean to include these pipeline changes why not remove them before merging this PR?

Copy link
Member Author

@davewalter davewalter Apr 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did mean to commit them. I just forgot to switch branch before doing so. IMHO, it wasn't important enough to update this PR and then create another PR with the CI change.

operations/use-online-windows2019fs.yml
operations/experimental/use-compiled-releases-windows.yml

- task: run-bosh-cleanup
file: cf-deployment-concourse-tasks/bosh-cleanup/task.yml
Expand Down