Skip to content
This repository has been archived by the owner on Feb 14, 2023. It is now read-only.

MAINT: remove internal cert #605

Merged
merged 7 commits into from
Jan 7, 2021
Merged

Conversation

jamespollard8
Copy link
Contributor

@jamespollard8 jamespollard8 commented Jan 5, 2021

We believe the internal cert is no longer necessary.

Next steps:

  • configure "plaintext" (Istio handled) via overlays instead of editing "vendired" files

Thanks for contributing to cf-for-k8s!

We've designed this PR template to speed up the PR review and merge process - please use it.

WHAT is this change about?

Ripping out the internal certificate if it's no longer needed.

Does this PR introduce a change to config/values.yml?

Yes. I'm not sure if removing a value is a breaking change.

Acceptance Steps

  1. PR tests pass
  2. When I review the codebase, I see no more references to the internal certificate

Things to remember

  • Make sure this PR is based off the develop branch
  • Include any links to related PRs, issues, stories, slack discussions, etc... that will help establish context.
  • Is there anything else of note that the reviewers should know about this change?
  • Our CI uses concourse task files from HEAD of the develop branch. If your PR includes/requires CI changes, please ping the RelInt interrupt and they'll help apply the CI changes for you.
  • Checkout the contributing guidelines

@cf-gitbot
Copy link
Collaborator

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/176372188

The labels on this github issue will be updated when the story is started.

@cf-rel-int-status-bot
Copy link

Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! 👀

1 similar comment
@cf-rel-int-status-bot
Copy link

Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! 👀

@cf-rel-int-status-bot
Copy link

Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! 👀

@jamespollard8 jamespollard8 changed the title WIP: remove internal cert MAINT: remove internal cert Jan 6, 2021
@Birdrock Birdrock self-requested a review January 7, 2021 19:08
@Birdrock
Copy link
Member

Birdrock commented Jan 7, 2021

@jamespollard8 Looks good to me. Squash/merge some of the commits to tidy up the history and I'd say it's ready.

@jamespollard8 jamespollard8 merged commit 94cdb08 into develop Jan 7, 2021
@jamespollard8 jamespollard8 deleted the jp-remove-internal-cert branch January 7, 2021 19:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants