Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI reveals passwords containing inverted commas #555

Closed
sjcorbett opened this issue Aug 18, 2015 · 3 comments
Closed

CLI reveals passwords containing inverted commas #555

sjcorbett opened this issue Aug 18, 2015 · 3 comments

Comments

@sjcorbett
Copy link

For example, if I changed my password to "hello-world:

$ CF_TRACE=true cf passwd

Current Password>

New Password>

Verify Password>
Changing password...

REQUEST: [2015-08-18T16:51:10+01:00]
PUT /Users/4238e7f5-4155-4730-b4ba-b72a909259de/password HTTP/1.1
Host: example.com
Accept: application/json
Authorization: [PRIVATE DATA HIDDEN]
Content-Type: application/json
User-Agent: go-cli 6.12.2-24abed3 / darwin

{"password":"[PRIVATE DATA HIDDEN]"hello-world","oldPassword":"[PRIVATE DATA HIDDEN]"}

Everything past the initial inverted comma has been revealed.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/101509044.

@sjcorbett
Copy link
Author

Using cf version 6.12.2-24abed3-2015-07-15T21:21:22+00:00.

@Zouuup
Copy link
Contributor

Zouuup commented Sep 17, 2015

nice catch @sjcorbett !

camelpunch added a commit that referenced this issue Sep 23, 2015
Handles passwords containing double quotes

Fixes #555
[finishes #103621532]
[fixes #101509044]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants