Add support for Korifi to the cf auth command
#2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `cf auth` normally requires a password. This change make the password optional when the CF API is Korifi, since we pull credentials from the user's KUBECONFIG in this case. - We also check the provided username against the available users from the k8s config to ensure that we will be able to use it. - Note that error messages for this command are not localized. My rationale was that other similar errors (like a missing/empty KUBECONFIG) also produce unlocalized errors. Maybe this reasoning is incorrect? If so, we can amend the PR.
PeteLevineA
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR modify CLI v6, CLI v7, or CLI v8?
v8
Description of the Change
cf login. This change adds support forcf auth.cf authnormally requires a password. This change make the password optional when the CF API is Korifi, since we pull credentials from the user's KUBECONFIG in this case.I've only made a PR for the
v8branch, based on the instructions in the contributing guidelines. Please let me know if you'd also like a separate PR formain.Why Is This PR Valuable?
This is useful to us for the same reasons that
cf authis useful in CF on VMs: It's much easier to interact with from automation scripts since it doesn't require us to pipe answers into the CLI from<STDIN>. This will be helpful for us as developers, but likely also for customers that interact with CF through CI pipelines.Why Should This Be In Core?
The
cf loginchanges are already in core (see #2233), so it would be odd to putcf authinto a plugin. (Also maybe not possible? I am not really sure)Applicable Issues
Related to #2233 and #2267
How Urgent Is The Change?
Not urgent, just useful.
Other Relevant Parties
CC @tcdowney @emalm @gcapizzi