Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccv3 api routes: add GetTasksRequest #2343

Merged
merged 2 commits into from Jun 8, 2023

Conversation

risicle
Copy link

@risicle risicle commented Oct 27, 2022

Does this PR modify CLI v6, CLI v7, or CLI v8?

Nope Yes, cli v8 (though technically only when used as a library)

Description of the Change

Simple addition of the basic /tasks endpoint to the ccv3 known routes as GetTasks

Why Is This PR Valuable?

External code using the ccv3 package sometimes needs to get task information unfiltered by app.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 27, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: risicle / name: Robert Scott (600621f)

@risicle risicle closed this Oct 27, 2022
@risicle risicle reopened this Oct 27, 2022
@risicle risicle marked this pull request as ready for review October 27, 2022 14:12
@risicle
Copy link
Author

risicle commented Oct 27, 2022

☝️ unsure why EasyCLA isn't playing ball. Am a member of https://github.com/alphagov and have filled out the linked form(s).

@risicle
Copy link
Author

risicle commented Nov 23, 2022

These failures appear to be spurious. Any way we could get this moving?

@risicle risicle force-pushed the ris-ccv3-router-get-tasks branch 2 times, most recently from 600621f to b7afe1b Compare December 6, 2022 10:44
@benjaminguttmann-avtq
Copy link

@a-b is there anything we can do to get this one merged?

@risicle
Copy link
Author

risicle commented Jan 4, 2023

Or is it just a matter of submitting a backport once it's merged to main?

no use in cli yet, but useful to have
@risicle
Copy link
Author

risicle commented Jan 24, 2023

Ok, re-targeted at v8

@benjaminguttmann-avtq
Copy link

@a-b :D is there anything left to get this one merged?

@a-b a-b merged commit 97f90a4 into cloudfoundry:v8 Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants