fix: hide password for create-service-broker (v8) #2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `cf create-service-broker` command did not allow the password to be specified as an environment variable or via a prompt, meaning that users with certain logging options ended up with a password in the log. This fix brings the `cf create-service-broker` and `cf update-service-broker` into line with `cf auth` and `cf login` which allow credentials to be specified via environment variables and interactive prompts.
|
Cherry-pick of #2400 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR modify CLI v6, CLI v7, or CLI v8?
Please see the contribution doc above or review Architecture Guide.
Description of the Change
The
cf create-service-brokercommand did not allow the password to be specified as an environment variable or via a prompt, meaning that users with certain logging options ended up with a password in the log. This fix brings thecf create-service-brokerandcf update-service-brokerinto line withcf authandcf loginwhich allow credentials to be specified via environment variables and interactive prompts.Why Is This PR Valuable?
It fixes a security issue that users have raised
Why Should This Be In Core?
Because it's a fix to an existing core command
Applicable Issues
List any applicable GitHub Issues here
How Urgent Is The Change?
Is the change urgent? If so, explain why it is time-sensitive.
Other Relevant Parties
Who else is affected by the change?